123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275 |
- /**
- * @fileoverview Prevent common casing typos
- */
- 'use strict';
- const PROP_TYPES = Object.keys(require('prop-types'));
- const Components = require('../util/Components');
- const docsUrl = require('../util/docsUrl');
- // ------------------------------------------------------------------------------
- // Rule Definition
- // ------------------------------------------------------------------------------
- const STATIC_CLASS_PROPERTIES = ['propTypes', 'contextTypes', 'childContextTypes', 'defaultProps'];
- const STATIC_LIFECYCLE_METHODS = ['getDerivedStateFromProps'];
- const LIFECYCLE_METHODS = [
- 'getDerivedStateFromProps',
- 'componentWillMount',
- 'UNSAFE_componentWillMount',
- 'componentDidMount',
- 'componentWillReceiveProps',
- 'UNSAFE_componentWillReceiveProps',
- 'shouldComponentUpdate',
- 'componentWillUpdate',
- 'UNSAFE_componentWillUpdate',
- 'getSnapshotBeforeUpdate',
- 'componentDidUpdate',
- 'componentDidCatch',
- 'componentWillUnmount',
- 'render'
- ];
- module.exports = {
- meta: {
- docs: {
- description: 'Prevent common typos',
- category: 'Stylistic Issues',
- recommended: false,
- url: docsUrl('no-typos')
- },
- messages: {
- typoPropTypeChain: 'Typo in prop type chain qualifier: {{name}}',
- typoPropType: 'Typo in declared prop type: {{name}}',
- typoStaticClassProp: 'Typo in static class property declaration',
- typoPropDeclaration: 'Typo in property declaration',
- typoLifecycleMethod: 'Typo in component lifecycle method declaration: {{actual}} should be {{expected}}',
- staticLifecycleMethod: 'Lifecycle method should be static: {{method}}',
- noPropTypesBinding: '`\'prop-types\'` imported without a local `PropTypes` binding.',
- noReactBinding: '`\'react\'` imported without a local `React` binding.'
- },
- schema: []
- },
- create: Components.detect((context, components, utils) => {
- let propTypesPackageName = null;
- let reactPackageName = null;
- function checkValidPropTypeQualifier(node) {
- if (node.name !== 'isRequired') {
- context.report({
- node,
- messageId: 'typoPropTypeChain',
- data: {name: node.name}
- });
- }
- }
- function checkValidPropType(node) {
- if (node.name && !PROP_TYPES.some((propTypeName) => propTypeName === node.name)) {
- context.report({
- node,
- messageId: 'typoPropType',
- data: {name: node.name}
- });
- }
- }
- function isPropTypesPackage(node) {
- return (
- node.type === 'Identifier'
- && node.name === propTypesPackageName
- ) || (
- node.type === 'MemberExpression'
- && node.property.name === 'PropTypes'
- && node.object.name === reactPackageName
- );
- }
- /* eslint-disable no-use-before-define */
- function checkValidCallExpression(node) {
- const callee = node.callee;
- if (callee.type === 'MemberExpression' && callee.property.name === 'shape') {
- checkValidPropObject(node.arguments[0]);
- } else if (callee.type === 'MemberExpression' && callee.property.name === 'oneOfType') {
- const args = node.arguments[0];
- if (args && args.type === 'ArrayExpression') {
- args.elements.forEach((el) => {
- checkValidProp(el);
- });
- }
- }
- }
- function checkValidProp(node) {
- if ((!propTypesPackageName && !reactPackageName) || !node) {
- return;
- }
- if (node.type === 'MemberExpression') {
- if (
- node.object.type === 'MemberExpression'
- && isPropTypesPackage(node.object.object)
- ) { // PropTypes.myProp.isRequired
- checkValidPropType(node.object.property);
- checkValidPropTypeQualifier(node.property);
- } else if (
- isPropTypesPackage(node.object)
- && node.property.name !== 'isRequired'
- ) { // PropTypes.myProp
- checkValidPropType(node.property);
- } else if (node.object.type === 'CallExpression') {
- checkValidPropTypeQualifier(node.property);
- checkValidCallExpression(node.object);
- }
- } else if (node.type === 'CallExpression') {
- checkValidCallExpression(node);
- }
- }
- /* eslint-enable no-use-before-define */
- function checkValidPropObject(node) {
- if (node && node.type === 'ObjectExpression') {
- node.properties.forEach((prop) => checkValidProp(prop.value));
- }
- }
- function reportErrorIfPropertyCasingTypo(propertyValue, propertyKey, isClassProperty) {
- const propertyName = propertyKey.name;
- if (propertyName === 'propTypes' || propertyName === 'contextTypes' || propertyName === 'childContextTypes') {
- checkValidPropObject(propertyValue);
- }
- STATIC_CLASS_PROPERTIES.forEach((CLASS_PROP) => {
- if (propertyName && CLASS_PROP.toLowerCase() === propertyName.toLowerCase() && CLASS_PROP !== propertyName) {
- context.report({
- node: propertyKey,
- messageId: isClassProperty
- ? 'typoStaticClassProp'
- : 'typoPropDeclaration'
- });
- }
- });
- }
- function reportErrorIfLifecycleMethodCasingTypo(node) {
- let nodeKeyName = node.key.name;
- if (node.key.type === 'Literal') {
- nodeKeyName = node.key.value;
- }
- if (node.computed && typeof nodeKeyName !== 'string') {
- return;
- }
- STATIC_LIFECYCLE_METHODS.forEach((method) => {
- if (!node.static && nodeKeyName.toLowerCase() === method.toLowerCase()) {
- context.report({
- node,
- messageId: 'staticLifecycleMethod',
- data: {
- method: nodeKeyName
- }
- });
- }
- });
- LIFECYCLE_METHODS.forEach((method) => {
- if (method.toLowerCase() === nodeKeyName.toLowerCase() && method !== nodeKeyName) {
- context.report({
- node,
- messageId: 'typoLifecycleMethod',
- data: {actual: nodeKeyName, expected: method}
- });
- }
- });
- }
- return {
- ImportDeclaration(node) {
- if (node.source && node.source.value === 'prop-types') { // import PropType from "prop-types"
- if (node.specifiers.length > 0) {
- propTypesPackageName = node.specifiers[0].local.name;
- } else {
- context.report({
- node,
- messageId: 'noPropTypesBinding'
- });
- }
- } else if (node.source && node.source.value === 'react') { // import { PropTypes } from "react"
- if (node.specifiers.length > 0) {
- reactPackageName = node.specifiers[0].local.name; // guard against accidental anonymous `import "react"`
- } else {
- context.report({
- node,
- messageId: 'noReactBinding'
- });
- }
- if (node.specifiers.length >= 1) {
- const propTypesSpecifier = node.specifiers.find((specifier) => (
- specifier.imported && specifier.imported.name === 'PropTypes'
- ));
- if (propTypesSpecifier) {
- propTypesPackageName = propTypesSpecifier.local.name;
- }
- }
- }
- },
- ClassProperty(node) {
- if (!node.static || !utils.isES6Component(node.parent.parent)) {
- return;
- }
- reportErrorIfPropertyCasingTypo(node.value, node.key, true);
- },
- MemberExpression(node) {
- const propertyName = node.property.name;
- if (
- !propertyName
- || STATIC_CLASS_PROPERTIES.map((prop) => prop.toLocaleLowerCase()).indexOf(propertyName.toLowerCase()) === -1
- ) {
- return;
- }
- const relatedComponent = utils.getRelatedComponent(node);
- if (
- relatedComponent
- && (utils.isES6Component(relatedComponent.node) || utils.isReturningJSX(relatedComponent.node))
- && (node.parent && node.parent.type === 'AssignmentExpression' && node.parent.right)
- ) {
- reportErrorIfPropertyCasingTypo(node.parent.right, node.property, true);
- }
- },
- MethodDefinition(node) {
- if (!utils.isES6Component(node.parent.parent)) {
- return;
- }
- reportErrorIfLifecycleMethodCasingTypo(node);
- },
- ObjectExpression(node) {
- const component = utils.isES5Component(node) && components.get(node);
- if (!component) {
- return;
- }
- node.properties.forEach((property) => {
- if (property.type !== 'SpreadElement') {
- reportErrorIfPropertyCasingTypo(property.value, property.key, false);
- reportErrorIfLifecycleMethodCasingTypo(property);
- }
- });
- }
- };
- })
- };
|